🏂 - rich logging (provide clarity to downstream devs seeing errors in console) #7524
+32
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johndpope
requested review from
Kosinkadink,
huchenlei,
ltdrdata,
pythongosssss,
robinjhuang,
webfiltered and
yoland68
as code owners
johndpope
changed the title
Contributor
|
I've had a simpler version of this for a while, which was mostly based on the code from sd_scripts You need to remove the default logging handler(s) to avoid the double-logging shown in your screenshot. import logging
from rich.console import Console
from rich.logging import RichHandler
if logging.root.handlers:
for handler in logging.root.handlers[:]:
logging.root.removeHandler(handler)
formatter = logging.Formatter(fmt="%(message)s", datefmt="%Y-%m-%d %H:%M:%S")
new_handler = RichHandler(console=Console(stderr=True))
new_handler.setFormatter(formatter)
logging.root.addHandler(new_handler)
NODE_CLASS_MAPPINGS = {}
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fellow devs watching PRs do check this - just a few lines of code changes.